Add back logging of queries #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes sfackler#492
|
Oh, nice call! |
sfackler
reviewed
Dec 16, 2019
| statement.name(), | ||
| params, | ||
| ); | ||
| encode(client, &statement, params)? |
sfackler
reviewed
Dec 16, 2019
| statement.name(), | ||
| params, | ||
| ); | ||
| encode(client, &statement, params)? |
There was a problem hiding this comment.
Can you run the params through slice_iter here? That should minimize extra instantiations of encode.
There was a problem hiding this comment.
Nevermind, will require a bit more work to make that happen. I'll deal with it on my end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #492
I also tried adding this piece of code to
Client::execute_rawbut this did not work because it breaks thecheck_sendtest.