Skip to content

Make incorrect number of paramaters an error #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

SvizelPritula
Copy link
Contributor

Modifies the query method and its siblings to return a new error type instead of panicking when the number of provided parameters doesn't match the number of parameters in the statement.

Closes #998.

@sfackler
Copy link
Owner

CI should be fixed if you rebase.

@SvizelPritula
Copy link
Contributor Author

I accidentally merged instead of rebasing. Hold on.

@SvizelPritula
Copy link
Contributor Author

Rebase completed, should be ready now.

@sfackler sfackler merged commit 4f54069 into sfackler:master Feb 25, 2023
@sfackler
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should query panic when the number of parameters doesn't match?
2 participants