Skip to content

add 1c to avoid quoting cache issues #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

add 1c to avoid quoting cache issues #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lib/buy/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ function QuoteAndBuy(props: { options: SfBuyOptions }) {
}

pricePerGpuHour = getPricePerGpuHourFromQuote(quote);
// Add 1 cent to price to make order more likely to fill
pricePerGpuHour += 1;
Comment on lines 197 to +199
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Adding 1 cent to pricePerGpuHour could cause precision issues since JavaScript numbers may not handle decimal arithmetic perfectly. Consider using a decimal library or moving the addition after converting to total price.


startAt = parseStartDateOrNow(quote.start_at);

Expand Down
Loading