Fixed Authentication, now with passing spec! #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 446c868.
…ut nonce to environment dependent functions
|
Why is MTGOX_ENV necessary? I don't like the idea of defining methods conditionally based on the environment. |
|
There is a nonce generated with every request that is time based. I have to hardcode that nonce for testing in order to be able to stub out the request. |
|
Seems like it would be better to just stub that function. |
|
Ah, that should work. I'll rework it and resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed up the authentication scheme in the tests as well as patched up a couple broken features. I guess that's why we have specs ;).