Duplexed streams #45
Merged
Duplexed streams #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops LibXML from writing to STDERR when testing.
hakanensari
force-pushed
the
duplexed-streams
branch
from
31dd2a6
to
498db34
Compare
I added this test when debugging Ox, which hangs when given a duplex stream. I managed to trick it to read the stream partially by monkey-patching the IO object in the test. @ohler55, I’m wondering if this is something that should be changed in Ox? The other wrappers handle the stream fine.
hakanensari
force-pushed
the
duplexed-streams
branch
from
498db34
to
c5a24f9
Compare
|
Ox failed in 1.8.7 and Rubinius for different reasons. The other failures are Rubocop noise. |
|
I'll update Ox tonight if I can to get the fix in. |
|
@sferik, perhaps it's a better idea not to use Rubocop here? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding test coverage for duplexed IO streams.
I ran into an issue with the Ox wrapper and included a workaround in the spec. All other wrappers work fine.
cc: @ohler55