-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eda): added density parameter to plot_diff(df) #698
Conversation
dfe8522
to
14bff24
Compare
return fig | ||
|
||
|
||
def kde_viz_panel( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the code of kde_viz_panel
is almost same as kde_viz_figure
. Could we just call kde_viz_figure
in kde_viz_panel
? E.g.,
fig = kde_viz_figure(...)
return panel(fig)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the kde_viz_panel
function, you could first get fig using kde_viz_figure
function, then warp it to the Panel type and return. In this way the code of generating fig part is not redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you're saying I misread it
Hi @devinllu , good job! I think we can merge the PR after you rebase and fix my last comment. |
14bff24
to
2c249a3
Compare
fb1b323
to
87e77df
Compare
feat(eda): added density parameter to plot_diff(df) refactor(eda): ran just ci tests refactor: changed kde_viz_panel() into a wrapper
2c249a3
to
323ae6b
Compare
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes Issue #683
How Has This Been Tested?
Manually tested via Jupyter Notebook
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Snapshot of tests included below
Snapshots:
Include snapshots for easier review.
Checklist: