Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the bar to POSIX.1-2008 #616

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Dec 22, 2022

However, don't stop using functions that were once required by POSIX.1-2001 that were good functions, and which have been removed by POSIX.1-2008 without good reasons. For example, continue using bzero(3). However, there may be functions that were removed with a good reason. We should stop using those.

That's required by POSIX.1-2008.

Link: <shadow-maint#600>
Cc: Christian Göttsche <cgzones@googlemail.com>
Cc: Iker Pedrosa <ipedrosa@redhat.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
It has been a requirement since at least C90, according to tm(3type).

Link: <shadow-maint#600>
Cc: Christian Göttsche <cgzones@googlemail.com>
Cc: Iker Pedrosa <ipedrosa@redhat.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
@alejandro-colomar
Copy link
Collaborator Author

alejandro-colomar commented Dec 22, 2022

I have one more change that could be included in this patch set, since it is part of upgrading to POSIX.1-2008, but since it's a quite complex change, and has important side effects, I'll keep it in a separate PR. So, this is ready! :)

@alejandro-colomar alejandro-colomar marked this pull request as ready for review December 22, 2022 11:20
Copy link
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikerexxe ikerexxe mentioned this pull request Dec 22, 2022
@hallyn hallyn merged commit 647d465 into shadow-maint:master Dec 22, 2022
@alejandro-colomar alejandro-colomar deleted the posix2008 branch December 22, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants