-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh, get some more numbers #899
Merged
alejandro-colomar
merged 18 commits into
shadow-maint:master
from
alejandro-colomar:getuh
Jul 2, 2024
Merged
Uh, get some more numbers #899
alejandro-colomar
merged 18 commits into
shadow-maint:master
from
alejandro-colomar:getuh
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
getuh
branch
7 times, most recently
from
January 21, 2024 00:40
655c95f
to
398a0d5
Compare
alejandro-colomar
force-pushed
the
getuh
branch
from
January 29, 2024 15:19
398a0d5
to
7bcc656
Compare
alejandro-colomar
force-pushed
the
getuh
branch
from
February 6, 2024 01:19
7bcc656
to
6044f90
Compare
alejandro-colomar
force-pushed
the
getuh
branch
2 times, most recently
from
February 20, 2024 00:08
30f73ba
to
dba0782
Compare
alejandro-colomar
force-pushed
the
getuh
branch
4 times, most recently
from
March 15, 2024 00:54
406269b
to
fe0cf33
Compare
v2 changes:
|
alejandro-colomar
force-pushed
the
getuh
branch
from
March 21, 2024 14:26
fe0cf33
to
0d39c58
Compare
v2b changes:
|
alejandro-colomar
force-pushed
the
getuh
branch
from
March 23, 2024 23:28
0d39c58
to
74ccb04
Compare
v2c changes:
|
alejandro-colomar
force-pushed
the
getuh
branch
from
March 29, 2024 19:37
74ccb04
to
1304c7f
Compare
v2d changes:
|
alejandro-colomar
force-pushed
the
getuh
branch
from
April 16, 2024 01:54
1304c7f
to
d3af3c9
Compare
v2e changes:
|
alejandro-colomar
force-pushed
the
getuh
branch
from
April 16, 2024 13:48
d3af3c9
to
3870492
Compare
v2f changes:
|
alejandro-colomar
force-pushed
the
getuh
branch
2 times, most recently
from
May 5, 2024 22:45
395b5cd
to
8a475e0
Compare
hallyn
approved these changes
Jul 2, 2024
…r2sl() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
The limit, since it's an unsigned int, should have been UINT_MAX, not INT_MAX. By calling a2ui() we can fix that and simplify too. Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
…tr2sl() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
…r2sl() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
…ad of str2ul() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
…str2sl() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
…f str2sl() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
…stead of str2ul() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
…str2sl() Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This reduces indentation. Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
spwd.sp_flag is an unsigned long, which can never be negative. Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Handle negative values as errors from a2sl(), and reuse its error-handling code. Cc: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
v5c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3
v3 changes:v4
v4 changes:v4b
v4c
v4d
v4e
v5
v5b