Hard-code a remaining case of Prog. #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're checking for "vigr", it makes more sense to name the variable accordingly. Signed-off-by: Alejandro Colomar <alx@kernel.org>
This avoids using argv[0], which is controlled by the user, and might inject arbitrary text in stderr and the logs. Link: <shadow-maint#959> Link: <shadow-maint#960> Cc: "Skyler Ferrante (RIT Student)" <sjf5462@rit.edu> Cc: "Serge E. Hallyn" <serge@hallyn.com> Cc: Karel Zak <kzak@redhat.com> Cc: Iker Pedrosa <ipedrosa@redhat.com> Cc: Christian Brauner <christian@brauner.io> Signed-off-by: Alejandro Colomar <alx@kernel.org>
hallyn
approved these changes
Mar 8, 2024
alejandro-colomar
added a commit
that referenced
this pull request
Mar 8, 2024
Since we're checking for "vigr", it makes more sense to name the variable accordingly. Signed-off-by: Alejandro Colomar <alx@kernel.org> Cherry-picked-from: 0ab893a ("src/vipw.c: Reverse logic and variable name") Link: <#962> [alx: This is needed by 89c4da4 ("src/vipw.c: Use string literals to initialize 'Prog'") Cc: Serge Hallyn <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
added a commit
that referenced
this pull request
Mar 8, 2024
This avoids using argv[0], which is controlled by the user, and might inject arbitrary text in stderr and the logs. Link: <#959> Link: <#960> Cc: "Skyler Ferrante (RIT Student)" <sjf5462@rit.edu> Cc: "Serge E. Hallyn" <serge@hallyn.com> Cc: Karel Zak <kzak@redhat.com> Cc: Iker Pedrosa <ipedrosa@redhat.com> Cc: Christian Brauner <christian@brauner.io> Cherry-picked-from: 89c4da4 ("src/vipw.c: Use string literals to initialize 'Prog'") Link: <#962> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: #959
Link: #960
Cc: @skyler-ferrante
Cc: @hallyn
Cc: @karelzak
Cc: @ikerexxe
Cc: @brauner