Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graceful shutdowns for fixed-size streams #43

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

robgjansen
Copy link
Member

For fixed-size streams where we know in advance what the send or recv length is going to be, we can do a graceful shutdown by sending application-layer FINs after we have read everything that the other side sent us. This helps ensure we don't close sockets before the data was actually received by the other end and lose data.

For non-fixed-sized streams that are driven only by a Markov model, the graceful shutdown procedure is skipped since the other end does not know when to expect the stream to end and where to look for the footer that contains the FIN.

@robgjansen robgjansen added the bug Something isn't working label Jan 19, 2023
@robgjansen robgjansen self-assigned this Jan 19, 2023
Copy link
Contributor

@stevenengler stevenengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with tgen, but it seems good to me.

I think there's still technically a small race condition here where a tgen connection receives a footer message, sends its own footer message, and closes the socket while its outgoing footer message is still sitting in the socket's outgoing queue. But since the number of bytes will be small, there's a very high chance that it will be received by the tor client and sent on the circuit before the socket leaves the TIME_WAIT state, and so the tgen connection will be successful.

src/tgen-stream.c Outdated Show resolved Hide resolved
src/tgen-stream.c Show resolved Hide resolved
src/tgen-stream.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants