fix(UI): Fix broken language names on Google TV #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 35cb193.
JulianDomingo
approved these changes
Sep 6, 2023
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
added a commit
that referenced
this pull request
Sep 8, 2023
Reverts #5365: "feat(UI): Use Intl.DisplayNames to show the language name" On the Google TV Chromecast just added to the lab, Intl.DisplayNames is returning the input as output again for some languages. For example, instead of `en` => `English`, we get `en` => `en`. Same for `fr`. Oddly, it works for some others, such as `zh`. We can follow up with a change that either avoids Google TV or that falls back to the internal map when Intl.DisplayNames returns its input as output.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5365: "feat(UI): Use Intl.DisplayNames to show the language name"
On the Google TV Chromecast just added to the lab, Intl.DisplayNames is returning the input as output again for some languages. For example, instead of
en=>English, we geten=>en. Same forfr. Oddly, it works for some others, such aszh.We can follow up with a change that either avoids Google TV or that falls back to the internal map when Intl.DisplayNames returns its input as output.