-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add js test with mocha and chai #137
Conversation
695f62b
to
be57ff1
Compare
@justin808 you're welcome - I hope it's useful. Either way I'm super interested in knowing what test stack you guys end up going with on your internal project. |
I found an issue on this branch: npm ERR! peerinvalid The package react@0.14.0 does not satisfy its siblings' peerDependencies requirements! I'll push a fix for this. |
@glennr I'm trying to run this, but it looks like a few more hours before we can update all.
See #35.
|
@justin808 I indeed forgot to npm-shrinkwrap after adding those deps (I recalled something to that extent, but couldn't find it in the Readme - I found it on your blog entry this morning). So there's a couple of issues on this branch now
I'm on a terribad 3g connection at the moment, so npm install has been a 'special' experience for me all morning. I'll check back in another few hours when npm install has hopefully completed :-) |
I had to upgrade react to 0.14.1 to be compatible with react-addons-test-utils. All specs pass OK. I think a lot of my issues were to do with my npm version, which I upgraded;
@justin808 - WRT the babel incompatibility - I had to run 'npm prune --production' to remove all local dev deps before npm shrinkwrap would work. Is that right? |
@justin808 - I've left the relevant unsquashed commits so its easier for you to review - but happy to squash them once you've given the +1 |
@@ -18,6 +18,7 @@ | |||
.env | |||
node_modules | |||
npm-debug.log | |||
client/npm-debug.log* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have this in there regardless! Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I just realized npm-debug.log* will suffice. All I wanted to do is ignore those timestamped npm-debug.log.201501...etc files
This looks great! 👍 Thank @glennr |
And my 👍 Thanks @glennr! |
@glennr Great! 👍 |
Awesome! |
This commit adds a JS unit testing framework with mocha and chai. Sample unit tests are provided for Comment and CommentList. Also updates react to 0.14.1 to satisfy a test-utils dependency
5f88dac
to
f94f13a
Compare
@glennr Can you please resolve the merge conflict and rebase again, and I'll merge. Thanks again. Awesome job! |
@glennr if you can take care of this, that would be great. I want to leave you in as the author. |
@glennr I'm taking care of this now. |
See #151 |
This commit adds a JS unit testing framework with mocha and chai.
Sample unit tests are provided for Comment and CommentList.
Fixes #9