remove unnecessary this binding for helper (ONLY needed for callbacks) #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| constructor(props, context) { | ||
| super(props, context); | ||
|
|
||
| _.bindAll(this, '_renderNotification'); |
There was a problem hiding this comment.
@MaMute Can you check this is actually required, meaning a binding of this.
The reason I ask is that it looks like this._renderNotifcation is simply a helper that returns either null or a react component.
I suspect that the fix is that that the :: was not needed.
marcusvmsa
force-pushed
the
convert-bindings-for-react-callbacks
branch
from
d7dc9e4
to
9118f87
Compare
|
@justin808 you're right, i've checked and fixed |
justin808
changed the title
justin808
added a commit
that referenced
this pull request
Dec 4, 2015
remove unnecessary this binding for helper (ONLY needed for callbacks)
|
Thanks. @alexfedoseev FYI... @MaMute I updated the title. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.