Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of console.group prevents grouping of similar logs #17

Open
ansiwen opened this issue Jul 15, 2020 · 0 comments · May be fixed by #19
Open

Use of console.group prevents grouping of similar logs #17

ansiwen opened this issue Jul 15, 2020 · 0 comments · May be fixed by #19

Comments

@ansiwen
Copy link

ansiwen commented Jul 15, 2020 •
edited
Loading

At least Chrome can group repeating similar log messages. The use of console.group() and console.groupCollapsed() in BrowserLogger seems to prevent that feature, which is unfortunate especially for often repeating debug output.
ansiwen added a commit to ansiwen/bs-log that referenced this issue Jul 15, 2020
@ansiwen
BrowserLogger: Use Console API functions for logs without data
66c8625 
The Console API of browsers offer several functions for logs of
different severity levels, like error, warn, info, debug. This change
uses these functions instead of groupCollapsed for simple logs without data.
This allows to filter for logs in the browser console and allows the
browser to automatically group repeating logs.

Fixes: shakacode#17, shakacode#18

Signed-off-by: Sven Anderson <sven@anderson.de>
@ansiwen ansiwen linked a pull request Jul 15, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BrowserLogger: Use Console API functions for logs without data ansiwen/bs-log
1 participant
@ansiwen