Skip to content

Conversation

shwstppr
Copy link
Member

@shwstppr shwstppr commented Mar 14, 2019

Description

Problem: Custom compute offering does not allow setting min and max values for CPU and VRAM for custom VMs.

Root Cause: Custom compute offerings cannot be created with a given range of CPU number and memory instead it allows only fixed values.

Solution: createServiceOffering API has been modified to allow setting a defined range for CPU number and memory. Also, UI form for compute offering creation is provided with a new field named 'compute offering type’ with values - Fixed, Custom Constrained, Custom Constrained. It will allow creation of compute offerings either with a fixed CPU speed and memory for fixed compute offering, or with a range of CPU number and memory range for custom constrained compute offering or without predefined CPU number, CPU speed and memory for custom unconstrained compute offering.

To allow user to set CPU number, CPU speed and memory during VM deployment, UI form for VM deployment has been modified to provide controls to change these values. These controls are depicted in screenshots below for custom constrained and custom unconstrained compute offering types.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Create compute offering form
Screenshot from 2019-03-12 17-32-13
Screenshot from 2019-03-12 17-32-17
Screenshot from 2019-03-12 17-32-22

VM deployment form
Screenshot from 2019-03-12 17-43-52
Screenshot from 2019-03-12 17-44-01

How Has This Been Tested?

Changes allow admin to create compute offerings with unconstrained CPU, Memory or constrained range CPU, memory which can be later set by user while deploying VM.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Member Author

Moved apache#3245

@shwstppr shwstppr closed this Mar 28, 2019
shwstppr added a commit that referenced this pull request Aug 16, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

ui: fix UI label bug #28 (#34)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix system vm migration with zone wide storage (#35)

* fix system vm migration with zone wide storage

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix spacing

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* add empty volumes check

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix fr568 issue #28 (#36)

Fixes systemvm migration with zone-wide storage
Check only for usable volumes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

vmware: fix error msg for vmotion without shared storage (#37)

Fixes error message which wrongly mentions worker VM

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

refactor error message for interpod systemvm migration (#38)

Fixes error message introduced in #28

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr added a commit that referenced this pull request Nov 23, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

ui: fix UI label bug #28 (#34)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix system vm migration with zone wide storage (#35)

* fix system vm migration with zone wide storage

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix spacing

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* add empty volumes check

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix fr568 issue #28 (#36)

Fixes systemvm migration with zone-wide storage
Check only for usable volumes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

vmware: fix error msg for vmotion without shared storage (#37)

Fixes error message which wrongly mentions worker VM

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

refactor error message for interpod systemvm migration (#38)

Fixes error message introduced in #28

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
vishesh92 pushed a commit that referenced this pull request Sep 9, 2024
* Prevent addition of duplicate PF rules on scale up and no rules left behind on scale down (#32)

* fix missing dependency injection

* NSX: Fix concurrency issues on port forwarding rules deletion (#37)

* Fix concurrency issues on port forwarding rules deletion

* Refactor objectExists

* Fix unit test

* Fix test

* Small fixes

* CKS: Externalize control and worker node setup wait time and installation attempts (#38)

* NSX: Add shared network support (#41)

* NSX: Fix number of physical networks for Guest traffic checks and leftover rules on CKS cluster deletion (#45)

* Fix pf rules removal on CKS cluster deletion

* Fix check for number of physical networks for guest traffic

* Fix unit test

* fix logger

* NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs

* NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs

* Remove unused string

* fix logger

* Update UDP active monitor to ICMP

* Fix NPE on restarting VPC with additional public IPs

* NSX / VPC: Reuse Source NAT IP from systemVM range on restarts

* CKS: Public IP not found for VPC networks

* Externalize retries and inverval for NSX segment deletion (#67)

* remove unused import

* remove duplicate imports

* remove unused import

* revert externalizing cks settings

* fix test

* Refactor log messages

* Address comments

* Fix issue caused due to forward merge: 90fe1d

---------

Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant