⬆️ Add support for mongodb v4
#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyhwang
reviewed
Jul 14, 2021
This change adds support for [`mongodb` v4][1]. The only [changes][2] that seem to affect us are: - removal of the top-level `connect()` function - removal of callbacks from `MongoClient.aggregate()` - disallowing of non-Mongo options being passed in the options object when connecting [1]: https://github.com/mongodb/node-mongodb-native/releases/tag/v4.0.0 [2]: https://github.com/mongodb/node-mongodb-native/blob/4.0/docs/CHANGES_4.0.0.md
ericyhwang
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
It does feel a bit weird copying and deleting the sharedb-mongo options properties before passing them in to the Mongo driver, but it's still fewer options than the Mongo driver takes, so we'll just have to remember to update the option-cleanup when we add options. Until we major-version and only allow passing via mongoOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
mongodbv4. The only changesthat seem to affect us are:
connect()functionMongoClient.aggregate()when connecting
Dependencies
mongodbdrivers #118