Skip to content

✅ Add async to devDependencies #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

✅ Add async to devDependencies #144

merged 1 commit into from
Feb 28, 2023

Conversation

alecgibson
Copy link
Contributor

We incorrectly removed async from our dependencies, but we still import this library for our tests.

This change puts it back in our devDependencies

@alecgibson
✅ Add async to devDependencies
eda5a69 
We incorrectly [removed `async`][1] from our dependencies, but we still
import this library for our tests.

This change puts it back in our `devDependencies`

[1]: https://github.com/share/sharedb-mongo/pull/140/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L7
@coveralls
Copy link

Coverage Status

Coverage: 92.128%. Remained the same when pulling eda5a69 on async-test into a49c324 on master.

@alecgibson alecgibson merged commit 5682d86 into master Feb 28, 2023
@alecgibson alecgibson deleted the async-test branch February 28, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alecgibson @coveralls @ericyhwang