Always include m in snapshot
#67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
bump-sharedb
branch
from
bb517f8 to
5aad190
Compare
|
@ericyhwang once you've released the new |
alecgibson
changed the title
m in snapshotm in snapshot
This change updates the `MongoSnapshot` class to always include the `m` field, in line with the [recent change to the core `Snapshot` class][1] [1]: https://github.com/share/sharedb/pull/220/files#diff-09a9af1416a54a5b125a5c2e1e6c2a30R7
alecgibson
force-pushed
the
bump-sharedb
branch
from
5aad190 to
ef673b7
Compare
|
@ericyhwang this should be good to merge now |
ericyhwang
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
MongoSnapshotclass to always include themfield, in line with the recent change to the core
SnapshotclassDependencies