Greenify build #92
Merged
Greenify build #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the new `sharedb` tests rely on `ot-json1` as a dependency. Without it, the tests fail to run. This change adds `ot-json1` as a `devDependency`. Note that we didn't need to do this for `ot-json0`, because `sharedb` ships with that as a `dependency`.
This change reverts 38d6f8a That change moved some tests from this library into `sharedb-mingo-memory` and then ran them in this library by requiring them from that one. While this de-duplicates code, it also introduces a surprising coupling between the tests of the two libraries. `sharedb-mingo-memory` can add arbitrary tests to the imported suite, which may not necessarily be applicable to `sharedb-mongo`, and even fail the `sharedb-mongo` build, as is happening now. This change removes that `require`, and just puts the original tests back (ignoring any other tests that have been added to that external suite since).
alecgibson
force-pushed
the
remove-mingo-tests
branch
from
5328d10 to
6280fd5
Compare
|
A couple of the Mongo 3.4 tests originally timed out. After signing out of Travis and signing back in, it recognized my orgs and let me re-run, and a re-run of those passed! |
ericyhwang
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change combines two commits that aim to greenify the build due to upstream library changes. This should also greenify the downstream
sharedbbuild.Remove
sharedb-mingo-memorytestsThis change reverts 38d6f8a
That change moved some tests from this library into
sharedb-mingo-memoryand then ran them in this library by requiringthem from that one.
While this de-duplicates code, it also introduces a surprising coupling
between the tests of the two libraries.
sharedb-mingo-memorycanadd arbitrary tests to the imported suite, which may not necessarily
be applicable to
sharedb-mongo, and even fail thesharedb-mongobuild, as is happening now.
This change removes that
require, and just puts the original testsback (ignoring any other tests that have been added to that external
suite since).
Add
ot-json1as adevDependencySome of the new
sharedbtests rely onot-json1as a dependency.Without it, the tests fail to run.
This change adds
ot-json1as adevDependency. Note that we didn'tneed to do this for
ot-json0, becausesharedbships with that as adependency.