Regression introduced in 1.0.0-beta.19 [now unpublished from NPM]

[zmillman]

Backend.prototype._sanitizeSnapshots was refactored with a new method signature here: https://github.com/share/sharedb/pull/263/files#diff-29d0f208724d5ac92c70f70e7e8c230eR295

Unfortunately, that method is also used in another file:

sharedb/lib/query-emitter.js

Line 190 in 76dc6de

emitter.backend._sanitizeSnapshots(emitter.agent, emitter.snapshotProjection, emitter.collection, snapshots, snapshotType, function(err) {

This breaks any middleware that is expecting to receive a request param -- it will receive a string as the request value instead.

[ericyhwang]

Thanks for the report, I've unpublished 1.0.0-beta.19 from NPM. (2019-02-15, ~02:30 UTC)

The regression wasn't caught by any tests in ShareDB, so I'll look to add a test for this case.

[ericyhwang]

Note - this only applies to 'readSnapshots' middleware for queryPoll() calls. So only clients that use query subscriptions and use that middleware are affected.

Document fetch/subscribe should have been unaffected.

[ericyhwang]

The change has also been reverted on master, for the sake of any forks.

I'll leave this issue open for a few days, for visibility.

[curran]

Suggest to close this as it's been resolved.