Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn at asset building time when a syntax definition context reference can't be resolved #1616

Closed
keith-hall opened this issue Apr 22, 2021 · 1 comment · Fixed by #1771
Closed

Warn at asset building time when a syntax definition context reference can't be resolved #1616

keith-hall opened this issue Apr 22, 2021 · 1 comment · Fixed by #1771
Labels
feature-request New feature or request good first issue Good for newcomers syntax-highlighting

Comments

@keith-hall
Copy link
Collaborator

keith-hall commented Apr 22, 2021 •
edited
Loading

It would be great to make use of the new syntect API to detect when a syntax definition has some context references (specifically push/set targets - missing includes are not such a problem and can be just treated as warnings) which couldn't be linked/resolved and fail the CI build. #915 (comment)
@keith-hall keith-hall added feature-request New feature or request good first issue Good for newcomers syntax-highlighting labels Apr 22, 2021
@sharkdp sharkdp mentioned this issue May 11, 2021
Closed
@sharkdp
Copy link
Owner

sharkdp commented May 11, 2021

Sounds great! Thank you for adding this in syntect!

@sharkdp sharkdp mentioned this issue Jun 29, 2021
Closed
@keith-hall keith-hall mentioned this issue Aug 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers syntax-highlighting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn when building assets from files if some referenced contexts are missing sharkdp/bat
2 participants
@sharkdp @keith-hall