Warn when building assets from files if some referenced contexts are missing #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enselic
reviewed
Aug 1, 2021
Enselic
approved these changes
Aug 1, 2021
sharkdp
approved these changes
Aug 1, 2021
keith-hall
force-pushed
the
warn_when_missing_contexts
branch
from
99dc7c8
to
8db1cd9
Compare
Enselic
approved these changes
Aug 2, 2021
|
@keith-hall Oh, I just noticed, seems like you forgot to git add the changes to |
Enselic
requested changes
Aug 2, 2021
|
Our CI is supposed to detect this, but it appears as if us forgetting to pass I just created a PR that fixes this. I verified that with this CI fix, this PR would cause CI to fail: |
keith-hall
force-pushed
the
warn_when_missing_contexts
branch
from
8db1cd9
to
50e1c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to syntect 4.6.0 and add a warning to stdout when building assets from files and some context references are unresolved. Fixes #1616 and makes it easier to work on #915 and prevent such cases occurring again in future :)