Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document --terminal-width=0 vs --wrap=never #535

Closed
luckydonald opened this issue Mar 30, 2019 · 6 comments
Closed

Document --terminal-width=0 vs --wrap=never #535

luckydonald opened this issue Mar 30, 2019 · 6 comments
Labels
bug Something isn't working documentation good first issue Good for newcomers

Comments

@luckydonald
Copy link

luckydonald commented Mar 30, 2019

I tried having it to not wrap.
But --terminal-width=0 results in a never ending loop of empty lines.
I later learned that --wrap=never was there, but maybe --terminal-width=0 could imply no wrapping.

In any way, I'd recommend including a mention of --wrap and --terminal-width into the comment of each others at the help output.

  --wrap <mode>                 
              Specify the text-wrapping mode (*auto*, never, character).
+             See '--terminal-width' to set when to wrap.
  --terminal-width <width>      
              Explicitly set the width of the terminal instead of determining it automatically. If
              prefixed with '+' or '-', the value will be treated as an offset to the actual terminal
-             width.
+             width. This controls when text should wrap, see  '--wrap'.
@sharkdp sharkdp added the bug Something isn't working label Apr 4, 2019
@sharkdp
Copy link
Owner

sharkdp commented Apr 4, 2019

Thank you for reporting this.

The endless-loop should definitely be fixed.

What would --terminal-width=0 imply for decorations such as the grid? Does it really make sense to allow for width 0 or should we disallow it and improve the documentation, as you suggested?

@luckydonald
Copy link
Author

Yeah probably adding references in the --help command and making it burp with a "did you mean" would be a cleaner solution.

@sharkdp
Copy link
Owner

sharkdp commented May 10, 2019

Closed via #559 by @eth-p.

@sharkdp sharkdp closed this as completed May 10, 2019
@luckydonald
Copy link
Author

Does it refer to wrap=never now?

@eth-p
Copy link
Collaborator

eth-p commented May 11, 2019

The documentation still needs to be updated, but it makes --terminal-width=0 an explicit error now.

@luckydonald
Copy link
Author

Can we keep this open please, until we get the documentation done?

@luckydonald luckydonald changed the title Let --terminal-width=0 behave like --wrap=never Document --terminal-width=0 vs --wrap=never May 13, 2019
@sharkdp sharkdp reopened this May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants