-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax test files for some languages #1381
Conversation
Awesome - thank you! Where do these files come from? Did you write them yourself? Or do we need LICENSE files for them?
The syntax file says: %YAML 1.2
---
name: Regular Expression
comment: Matches PCRE's regexp syntax, used in various languages and in
Sublime Text for the Find panels
file_extensions:
- re So I think either a single line PCRE regex or maybe a multi-line regex, but not multiple regexes on multiple lines. |
I have hacked them from either language's documentation and/or took reference from
So email regex from this, should work? |
So the syntax's for which test are added:
|
👍
In principle, yes. But note that StackOverflow has a non-trivial license file. We can't just copy that regex into our code base without attribution. A simpler self-written regex (maybe from our own Manpage sublime syntax) would also be a good start. |
I wanted to use as many regex identifiers(not sure if that's the correct word) as possible but then it's hard to come up with a useful regex. Although I think usefulness is not a concern here so I have came up with this:
And this matches
Would that be okay? PS: Check failed due to unrelated reasons |
Yes, thanks!
Yes. That was my bad. It should hopefully work if you rebase on master. |
Thank you! |
re: #1213
After hacktoberfest I didn't see any activity on the issue, so I have added basic test files for bolded languages on the issue.
Now only remaining is
Regular Expression
. What kind of structure of the file should be (as in just regular expression each on a new line)? and should it be PCRE, or javascript one?