Improve readability

[matklad]

Using Paths for paths expresses intent more clearly.

Drive by change mostly, I just accidentally fell into non-utf8 arguments pit :)

[matklad]

Note that here we don't need a conversion back from Path.

[matklad]

This adds support for non-utf8 names

[Enselic]

I haven't done a detailed review yet, but am in general positive to this change after skimming it through.

I'm curious what problem you saw with non-UTF-8 file names though? Works OK for me at least, using official build of bat 0.18.0 on x86_64-unknown-linux-gnu:

% echo testing > $(printf "\x$(printf %x 130)")       
% bat $(printf "\x$(printf %x 130)") 
───────┬────────────────────────────────
       │ File: �
───────┼────────────────────────────────
   1   │ testing
───────┴────────────────────────────────
% bat --version                                                 
bat 0.18.0

[matklad]

@Enselic you need to check with the file-names argument

[sharkdp]

Thank you for your contribution!

The changes look good. This is (at least technically) a breaking change, so it should be documented as such in the "bat as a library" section of the CHANGELOG.md. Changing AsRef<OsStr> to AsRef<Path> is unlikely to cause any problems (I guess), but the changes for Input::ordinary_file and Input::with_name could lead to errors in client code. Maybe we could accept AsRef<Path> for these methods as well? That would still allow users to pass in OsStrs, I believe.

[Enselic]

Thanks, with --file-names I can confirm that it crashes:

% bat --file-names $(printf "\x$(printf %x 130)")      
thread 'main' panicked at 'unexpected invalid UTF-8 code point', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-2.33.3/src/app/parser.rs:1683:33
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[matklad]

Yeah, makes sense, updated!