Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LiveScript syntax + Svelte with LiveScript panic regression test #1915

Merged
merged 2 commits into from
Oct 23, 2021

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Oct 23, 2021

Not only do we get support for a new syntax, we also make bat not panic in Svelte files with embedded LiveScript code (for which this PR also contains a regression test). See #1912 (and #915) for more context.

Adding this syntax also means less "unresolved context reference" warnings when building assets. Now these are the only ones that remain:

- Syntax 'Svelte' with scope 'text.html.svelte' has unresolved context reference ByScope { scope: <source.postcss>, sub_context: None }
- Syntax 'Vue Component' with scope 'text.html.vue' has unresolved context reference ByScope { scope: <source.postcss>, sub_context: None }
- Syntax 'Vue Component' with scope 'text.html.vue' has unresolved context reference ByScope { scope: <source.sss>, sub_context: None }
- Syntax 'Vue Component' with scope 'text.html.vue' has unresolved context reference ByScope { scope: <text.jade>, sub_context: None }
- Syntax 'Vue Component' with scope 'text.html.vue' has unresolved context reference ByScope { scope: <text.pug>, sub_context: None }
- Syntax 'Vue Component' with scope 'text.html.vue' has unresolved context reference ByScope { scope: <text.slm>, sub_context: None }

The added syntax has 10k downloads on Package Control: https://packagecontrol.io/packages/LiveScript

The file `LiveScript.sublime-syntax` is a pure export from a licenced version
of Sublime Text, Version 3.1.1, Build 3176 with
assets/syntaxes/02_Extra/LiveScript/Syntaxes/LiveScript.tmLanguage as the source
file.
Without a LiveScript syntax present, the Svelte test will now fail with a panic.
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Enselic Enselic merged commit dde770a into sharkdp:master Oct 23, 2021
@Enselic Enselic deleted the live-script branch October 23, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants