Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bat cache --clear not clearing the --target dir if specified #2393

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Fix bat cache --clear not clearing the --target dir if specified #2393

merged 1 commit into from
Nov 19, 2022

Conversation

miles170
Copy link
Contributor

@miles170 miles170 commented Nov 3, 2022

Closes #2392.

@miles170 miles170 force-pushed the issue-2392-cache-clear-target-dir branch from 5248144 to 83c7b83 Compare November 3, 2022 03:14
Enselic
Enselic requested changes Nov 3, 2022
View reviewed changes
src/bin/bat/assets.rs Outdated Show resolved Hide resolved
@miles170 miles170 force-pushed the issue-2392-cache-clear-target-dir branch from 83c7b83 to 91eeab9 Compare November 3, 2022 07:04
@miles170 miles170 marked this pull request as draft November 3, 2022 07:24
@miles170 miles170 force-pushed the issue-2392-cache-clear-target-dir branch from 91eeab9 to ebdc1be Compare November 3, 2022 07:43
@miles170 miles170 marked this pull request as ready for review November 3, 2022 07:43
@miles170 miles170 requested a review from Enselic November 8, 2022 06:58
@Enselic
Copy link
Collaborator

Enselic commented Nov 8, 2022

Thanks for the update. Before I review, can you fix the lint warnings please? See https://github.com/sharkdp/bat/pull/2393/files

@miles170 miles170 force-pushed the issue-2392-cache-clear-target-dir branch from ebdc1be to 4e37416 Compare November 8, 2022 07:14
Enselic
Enselic reviewed Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks to me like a very nice step in the right direction. Only had some nits.

src/bin/bat/assets.rs Outdated Show resolved Hide resolved
src/bin/bat/main.rs Outdated Show resolved Hide resolved
src/bin/bat/main.rs Outdated Show resolved Hide resolved
src/bin/bat/main.rs Outdated Show resolved Hide resolved
@miles170 miles170 force-pushed the issue-2392-cache-clear-target-dir branch from 4e37416 to e39178b Compare November 19, 2022 10:00
Enselic
Enselic approved these changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again

@sharkdp sharkdp merged commit 416845d into sharkdp:master Nov 19, 2022
@miles170 miles170 deleted the issue-2392-cache-clear-target-dir branch November 20, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enselic Enselic Enselic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bat cache --clear should clear the --target dir if specified
3 participants
@miles170 @Enselic @sharkdp