-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JSONC and aws credentials to the syntax mappings #2795
Conversation
Thank you for the PR. Let's wait with this PR until after #2755 has landed to avoid creating conflicts. |
Thanks for the update, let me know when it's viable to get this added, I'll fix the branch/pr conflicts then 😄 |
#2755 is now merged |
I'm pretty sure no actual changes were made to what mappings are applied by default in that PR, and I see no mention of JSONC in the changes |
Alright, I'll rebase this PR on new master branch |
I've applied my changes to the new structure, not 100% sure that it's done correctly though, let me know if anything needs changing. |
Shouldn't AWS |
I'm not sure, the official amazon docs that I looked at did not mention if it was toml formatted, but from the examples, it looks like simple INI format to me. Granted, basic INI if I remember correctly is valid TOML as well. |
conclusion: INI is correct 👍️ |
I'm not 100% sure this is where these should be added.
Let me know if I need to move them somewhere else.