-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About release 8.5.3 #1184
Comments
There was a little weirdness with the 8.5.3 release. I think that the v8.5.3 tag should be pointing to f6e7440 instead. I'm not entirely sure how it ended up pointing to a more recent commit. |
is the release manually done? |
It looks like the current tag was created by the GitHub release. Maybe you didn't push the tag when you released 8.5.3? @chenrui333 The release process is documented here: https://github.com/sharkdp/fd/blob/master/doc/release-checklist.md |
that helps! |
Closing this issue for now as I have rebottle on my end. Thanks folks! |
It would be sensible if we could determine what caused this re-tag to avoid it and bump version instead in the future. |
sharkdp/fd#1184 says that the release tag shifted for some mysterious reason. I confirmed that this tag was correct by building the fd derivation with no substituters.
If the tag is pointing to a wrong commit then please correct it and force push the correct tag. |
I created a new 8.6.0 release. |
sharkdp/fd#1184 says that the release tag shifted for some mysterious reason. I confirmed that this tag was correct by building the fd derivation with no substituters. (cherry picked from commit 82eed31)
👋 Just curious if the 8.5.3 release got re-tagged? Found the checksum mismatch when regression testing against rust 1.65.0 release, raising this issue to double confirm. Thanks!
The text was updated successfully, but these errors were encountered: