Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About release 8.5.3 #1184

Closed
chenrui333 opened this issue Nov 25, 2022 · 8 comments
Closed

About release 8.5.3 #1184

chenrui333 opened this issue Nov 25, 2022 · 8 comments

Comments

@chenrui333
Copy link

👋 Just curious if the 8.5.3 release got re-tagged? Found the checksum mismatch when regression testing against rust 1.65.0 release, raising this issue to double confirm. Thanks!

@tmccombs
Copy link
Collaborator

There was a little weirdness with the 8.5.3 release. I think that the v8.5.3 tag should be pointing to f6e7440 instead. I'm not entirely sure how it ended up pointing to a more recent commit.

@chenrui333
Copy link
Author

is the release manually done?

@tavianator
Copy link
Collaborator

It looks like the current tag was created by the GitHub release. Maybe you didn't push the tag when you released 8.5.3?

@chenrui333 The release process is documented here: https://github.com/sharkdp/fd/blob/master/doc/release-checklist.md

@chenrui333
Copy link
Author

The release process is documented here: https://github.com/sharkdp/fd/blob/master/doc/release-checklist.md

that helps!

@chenrui333
Copy link
Author

Closing this issue for now as I have rebottle on my end. Thanks folks!

@tranzystorekk
Copy link

It would be sensible if we could determine what caused this re-tag to avoid it and bump version instead in the future.

endgame added a commit to endgame/nixpkgs that referenced this issue Dec 6, 2022
sharkdp/fd#1184 says that the release
tag shifted for some mysterious reason. I confirmed that this tag
was correct by building the fd derivation with no substituters.
@SuperSandro2000
Copy link

If the tag is pointing to a wrong commit then please correct it and force push the correct tag.

@tmccombs
Copy link
Collaborator

tmccombs commented Dec 9, 2022

I created a new 8.6.0 release.

wizeman pushed a commit to wizeman/nixpkgs that referenced this issue Dec 14, 2022
sharkdp/fd#1184 says that the release
tag shifted for some mysterious reason. I confirmed that this tag
was correct by building the fd derivation with no substituters.

(cherry picked from commit 82eed31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants