Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustfmt to format the source code #99

Closed
Detegr opened this issue Oct 11, 2017 · 3 comments
Closed

Use rustfmt to format the source code #99

Detegr opened this issue Oct 11, 2017 · 3 comments

Comments

@Detegr
Copy link
Contributor

Detegr commented Oct 11, 2017

Rustfmt automatically formats Rust code to conform Rust style guide. The current code base of fd is hand formatted and I think it would be easier for contributors if we formatted the code with rustfmt.

What do you think? If there's some irritating style decisions in rustfmt, it is possible to tweak it to some extent.

@Detegr
Copy link
Contributor Author

Detegr commented Oct 11, 2017

For a reference, I pushed a commit to my fork which formats the repo using rustfmt with default settings.

@sharkdp
Copy link
Owner

sharkdp commented Oct 11, 2017

Sounds good!

Should we also enforce this via Travis/Appveyor in the future? Can rustfmt be used as a checker?

@Detegr
Copy link
Contributor Author

Detegr commented Oct 11, 2017

Yes, it should be possible. I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants