Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate TARGET in the install and build step #133

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Incorporate TARGET in the install and build step #133

merged 2 commits into from
Oct 20, 2017

Conversation

matematikaadit
Copy link
Contributor

  • Tidying up the build matrix
    • All channels has TARGET env var
    • Build against this targets:
      • x86_64-unknown-linux-gnu
      • x86_64-unknown-linux-musl
      • i686-unknown-linux-gnu
      • i686-unknown-linux-musl
      • x86_64-apple-darwin
    • Code formating check has it's own item in the build matrix
  • Prevent target re-add error from rustup
  • Incorporate the TARGET env var in the install and script stage

fix #132

@matematikaadit
Incorporate TARGET in the install and build step
af670b7 
- Tidying up the build matrix
  - All channels has TARGET env var
  - Build against this targets:
    - x86_64-unknown-linux-gnu
    - x86_64-unknown-linux-musl
    - i686-unknown-linux-gnu
    - i686-unknown-linux-musl
    - x86_64-apple-darwin
  - Code formating check has it's own item in the build matrix
- Prevent target re-add error from rustup
- Incorporate the TARGET env var in the `install` and `script` stage
@sharkdp
Copy link
Owner

sharkdp commented Oct 19, 2017

Very cool, thank you very much for your contribution!

Do you think there is some way to reduce the total CI time a bit? Previously, Travis was running in 20-30min. Now it takes 1h 15min. Maybe we don't have to build nightly and beta for every target?

@matematikaadit
Copy link
Contributor Author

matematikaadit commented Oct 19, 2017 •
edited
Loading

Feel free to exclude any matrix item. I just listed all of them because they're readily available and adding them is no hassle.

Probably only test for x86_64-unknown-linux-gnu on nightly and beta and remove the other target? Also, the target that listed under the # Stable channel. comment might become the one for the release deployment (issue #76). Feel free to drop any item that we don't wanna add to the release.

@sharkdp
Copy link
Owner

sharkdp commented Oct 20, 2017

Probably only test for x86_64-unknown-linux-gnu on nightly and beta and remove the other target?

Sounds good (maybe just comment them out for now). Would you like to include this within this PR?

@matematikaadit
Copy link
Contributor Author

With pleasure.

Disabling:

  • x86_64-unknown-linux-musl
  • i686-unknown-linux-gnu
  • i686-unknown-linux-musl
  • x86_64-apple-darwin

on beta and nightly channels.

@sharkdp sharkdp merged commit d2d2c31 into sharkdp:master Oct 20, 2017
@sharkdp
Copy link
Owner

sharkdp commented Oct 20, 2017 •
edited
Loading

Thank you very much!!

Could you please sign #105?

@matematikaadit
Copy link
Contributor Author

Your welcome

Nice, total CI build time reduced to 16 minutes. 😄

Also I have some suspicion about what causing the failing code formatting check on nightly. Currently investigating it.

@matematikaadit matematikaadit deleted the fix_travis_TARGET branch October 20, 2017 07:09
@pickfire
Copy link
Contributor

Maybe we could include fd.1 along with the compressed tarball? Reference implementation https://github.com/BurntSushi/ripgrep/blob/master/.travis.yml#L52-L53

@sharkdp What do you think?

@matematikaadit
Copy link
Contributor Author

Better place to discuss it I think is #76 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current setting in .travis.yml isn't using the TARGET env var for building the project
3 participants
@matematikaadit @sharkdp @pickfire