Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .fdignore files #241

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Add support for .fdignore files #241

merged 2 commits into from
Feb 21, 2018

Conversation

sharkdp
Copy link
Owner

@sharkdp sharkdp commented Feb 21, 2018

  • Respect .fdignore files
  • Do not respect .ignore and .rgignore files (anymore)

See #156

@sharkdp
Copy link
Owner Author

sharkdp commented Feb 21, 2018

There seems to be a small performance regression when using ignore-0.4.1 instead of ignore-0.2.0.

Before:

Benchmark #1: fd -HI '.*[0-9]\.jpg$' '/home/shark'

  Time (mean ± σ):     820.9 ms ±  35.5 ms    [User: 3.654 s, System: 2.547 s]
 
  Range (min … max):   790.1 ms … 904.1 ms

Now:

Benchmark #1: fd -HI '.*[0-9]\.jpg$' '/home/shark'

  Time (mean ± σ):     865.8 ms ±  42.5 ms    [User: 3.994 s, System: 2.454 s]
 
  Range (min … max):   834.5 ms … 975.4 ms

@sharkdp sharkdp merged commit b4be1f1 into master Feb 21, 2018
@sharkdp sharkdp deleted the fdignore-files branch February 21, 2018 21:55
@sharkdp sharkdp mentioned this pull request Feb 21, 2018
@sharkdp
Copy link
Owner Author

sharkdp commented Mar 7, 2018

Performance regression is due to BurntSushi/ripgrep#835

@sharkdp sharkdp added this to the 7.0 milestone Mar 13, 2018
RobbieClarken added a commit to RobbieClarken/dotfiles that referenced this pull request May 1, 2018
fd has switchted to using .fdignore instead of .ignore:
sharkdp/fd#241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant