Split internals.rs into module #340
Conversation
This PR splits `internals.rs` into the `internal` module with multiple files, and moves `FdOptions` into `opts.rs`. The main motivation behind this is to move logic for constructing `FdOptions` out of the main function and more readable and easier to understand in the `opts` module. The goal will eventually to be able to write `FdOptions::from(matches)` and have the options constructed.
There was a problem hiding this comment.
This PR splits
internals.rsinto theinternalmodule with multiple files, and movesFdOptionsintoopts.rs.
Awesome! This module has grown into a giant collection of unrelated things and a refactoring was overdue. Thank you very much.
The main motivation behind this is to move logic for constructing
FdOptionsout of the main function and more readable and easier to understand in theoptsmodule. The goal will eventually to be able to writeFdOptions::from(matches)and have the options constructed.
Sounds great!
This PR is hard to review in detail. I guess there are no significant changes to the parts of the code that have been moved around?
| @@ -6,19 +6,22 @@ | |||
| // notice may not be copied, modified, or distributed except | |||
| // according to those terms. | |||
|
|
|||
| use ansi_term; | |||
| use std::{ | |||
There was a problem hiding this comment.
Wow, I didn't know this was possible :-)
|
Unfortunately, there are probably horrible merge conflicts now due to the merge of #339. |
|
All good about the merge conflicts 😄 Yep there are no major code changes in this PR it's mainly just moving stuff around. One change which might be worth mentioning though is in |
|
Closing in favor of #341 |
This PR splits
internals.rsinto theinternalmodule with multiple files, and movesFdOptionsintoopts.rs.The main motivation behind this is to move logic for constructing
FdOptionsout of the main function and more readable and easier to understand in theoptsmodule. The goal will eventually to be able to writeFdOptions::from(matches)and have the options constructed.