is_dir: do not check for existence of directory #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build from this branch for testing: fd-v8.2.1-x86_64-pc-windows-msvc.zip.zip |
|
The test with a ImDisk virtual drive was successful. But now the actual check doesn't work anymore and |
This fixes a bug on Windows where `fd` could not be used on ram disks and encrypted folders. closes #752
|
The new approach should hopefully fix both issues. And maybe even #365 |
sharkdp
force-pushed
the
fix-752
branch
3 times, most recently
from
a6e205a
to
aa91121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug on Windows where
fdcould not be used on ram disksand encrypted folders.
closes #752