Faster colors #853
Merged
Faster colors #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavianator
force-pushed
the
faster-colors
branch
from
bf8636d
to
70c3529
Compare
tavianator
commented
Sep 17, 2021
tavianator
force-pushed
the
faster-colors
branch
from
70c3529
to
6c7c238
Compare
|
This looks really great - thank you very much. I'd like to do a bit more testing before I approve this, but I'm definitely ok with the "regression" in functionality. |
|
I even have an idea of how to bring the per-component colors back, but it would need changes to |
sharkdp
reviewed
Nov 14, 2021
Comment on lines
+63
to
+69
| for c in path_str[offset..].chars() { | ||
| if std::path::is_separator(c) { | ||
| offset += c.len_utf8(); | ||
| } else { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't understand how this code could be triggered? Wouldn't this imply that the final path component has another path separator inside?
There was a problem hiding this comment.
Say the (user supplied) path is a/b///c. parent will be a/b. This loop then advances the length to include a/b///.
sharkdp
approved these changes
Nov 14, 2021
It can be expensive to color each path component separately, requiring a stat() call on each component. For deep hierarchies this can result in quadratic overhead. Instead, just color the path up to the basename as a directory. Fixes sharkdp#720.
sharkdp
force-pushed
the
faster-colors
branch
from
6c7c238
to
13390b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can give a significant performance benefit:
Fixes #720. On the other hand, it does lose the distinct colors for
symlinks along the path, as you mentioned in
#720 (comment).