Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --case-insensitive (-i) #95

Merged
merged 1 commit into from Oct 12, 2017
Merged

Add --case-insensitive (-i) #95

merged 1 commit into from Oct 12, 2017

Conversation

jakwings
Copy link
Contributor

ping #85

@jakwings
Copy link
Contributor Author

Need --smart-case (-S)?

@jakwings
Copy link
Contributor Author

Rename this flag as --ignore-case?

@sharkdp
Copy link
Owner

sharkdp commented Oct 11, 2017

Looks great, thank you very much for your contribution!

-i/--ignore-case is perfect, as it is analogous to ripgrep.

I will properly review this later today.

One thing I was wondering is whether we could hide some of the options from the short -h text (maybe not from the long --help text). I would somehow like to keep the -h text short and concise, with only the most often used options.

@sharkdp sharkdp self-requested a review October 11, 2017 06:19
sharkdp
sharkdp previously approved these changes Oct 11, 2017
@sharkdp sharkdp dismissed their stale review October 11, 2017 18:00

Forgot about the argument hiding

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we can think about potentially hiding this from the -h text later. Looks great!

Could you rebase this? Let me know if you need any help.

@jakwings
Copy link
Contributor Author

Rebased.

@sharkdp sharkdp merged commit e075e1c into sharkdp:master Oct 12, 2017
@sharkdp
Copy link
Owner

sharkdp commented Oct 12, 2017

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants