Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gitignore, Corrected typos, Added config #5

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Added gitignore, Corrected typos, Added config #5

merged 2 commits into from
Oct 1, 2022

Conversation

meetagrawal09
Copy link
Contributor

  1. .gitignore to remove node_modules
  2. Removed non-required packages
  3. Corrected typos causing build failure
  4. Used config to store the secret encryption key separately and thus not exposing it directly in code

@meetagrawal09 meetagrawal09 mentioned this pull request Sep 30, 2022
Open
3 tasks
@meetagrawal09
Copy link
Contributor Author

meetagrawal09 commented Oct 1, 2022 •
edited
Loading

There was some issue with some packages being referenced from that external package.json (which we decided on removing)
I have tested the project now. Works perfectly !!!
A request to expedite the review and merge for this PR so that other developers working on this project do not face issues 🙂

@shazm12 shazm12 added bug Something isn't working enhancement New feature or request hacktoberfest labels Oct 1, 2022
@shazm12
Copy link
Owner

shazm12 commented Oct 1, 2022

Great work, @meetagrawal09 !

@shazm12 shazm12 merged commit c34e02c into shazm12:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meetagrawal09 @shazm12