Elm syntax highlighting with PrismJS #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prism now supports syntax highlighting for elm, thanks to PrismJS/prism#1174. This makes it possible to highlight elm code in the markdown output, which is what I implemented in this PR.
Because mume partially relies on
dependencies/*.js
instead ofnode_modules
, here are the details of how I updateddependencies/prism.js
:dependencies/prism.js
Prism.languages.elm=
and staged itThis means that PrismJS has not been updated as a whole. Although this ensures that mume does not break with this PR, it'd be great to generally keep in sync with prism as it gets updated. @shd101wyy could you please briefly describe how to generate
dependencies/prism.js
from source insidedependencies/README.md
?To be honest, I'd prefer to just sticking with
node_modules
, but I imagine there's been a really good reason to switch to a custom dependency management. Just curious: in which scenarios largenode_modules
ended up being a pain formume
? Can't remember that in other Node.js (i.e. not-in-browser) projects.