No hook key needed when using precompiled hooks #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, cool looks good. I was initially suspicious about the test removal but they were a NOOP anyway👍🏻 |
|
I have no permissions to either merge or release on this repo so it's up to you! 😄 |
|
Hah, OK, I'll need to be at another computer to do this so I'll add you and ship when I get back |
|
think that's everything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rewritten the flow of the execution to allow Komondor to fit the new
PackageConfigcapability of using precompiled binaries which might have hooks recorded in them that Komondor does not find in thePackage.swift. This way we just warn the user that the hook did nothing and exit gracefully of the hook. It still exits with an error if cannot find thekomondorkey under the configuration being loaded.