Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install only desired hooks #54

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Conversation

minuscorp
Copy link
Collaborator

This PR adds the ability to install all the hooks as it was before or specify the list by a whitespace separated list the names of the commits that the user wants to be installed.

@orta
Copy link
Member

orta commented Mar 3, 2022

Interesting, seems fine - what's the use case for only installing a subset of the hooks?

@minuscorp
Copy link
Collaborator Author

minuscorp commented Mar 3, 2022

In our case, for some users using Git GUIs, they're getting strange status codes when executing empty hooks, also, we also manage some subset of hooks outside of Komondor's domain, which is not allowed now because it is overwritten by Komondor, even if you could delete and replace those files. Just to let the teams introduce a subset of hooks when they need them instead of having Komondor having written them all.

Also, people like us that vendor a dynamic library with hooks which source is opaque for the developer, we want to introduce them gradually without having to release a new library and recompile everything from scratch.

@orta
Copy link
Member

orta commented Mar 3, 2022

👍🏻 sounds good to me then

@orta orta merged commit dedffea into shibapm:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants