Skip to content

#80 enhance tests #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 30, 2018
Merged

#80 enhance tests #82

merged 22 commits into from
Nov 30, 2018

Conversation

simonmumenthaler
Copy link
Contributor

closes #80

@simonmumenthaler
test(random-exponential-backoff-timer): write test
3b89ad7
@simonmumenthaler
test(scan-request): add test for log statements
63c2f9d
@simonmumenthaler
test(fetch-all): add tests
5a0273d
@simonmumenthaler
fix(update-config): throw when invalid dateMapper was given
c5d0894
@simonmumenthaler
test(update-config): add tests
3841a2f
@simonmumenthaler
fix(update-config): fix check if dateMapper arg is invalid
33240a2
@simonmumenthaler
test(dynamo-rx): add tests
91f7a9f
@simonmumenthaler
test(dynamo-store): add tests for session validity ensurer + logger
99d3baf
@simonmumenthaler
test(batch-get-single-table-request): add tests for constructor and l…
b2a2b38 
…ogger
@simonmumenthaler
test(get-request): add test for constructor, params, exec, logger
0788904
@simonmumenthaler
test(batch-get-request): add tests for forModel, mapping
6740586
@simonmumenthaler
test(dynamo-store): add tests for request-methods
275d2d4
@simonmumenthaler
test(default-session-validity-ensurer): add test
2a6f5b2
@simonmumenthaler
test(requests): add tests for logger
2622095
@simonmumenthaler
test(base-request): add test for constructor
b26b525
@simonmumenthaler
test(write-request): add test
b87859d
@simonmumenthaler
test(scan-request): add tests for exec and condition functions
24e8076
@simonmumenthaler
test(query-request): add tests for scan direction, exec functions
bae50ba
@simonmumenthaler
test(metadata): add tests
e9ce159
@simonmumenthaler
test(dynamo-rx): add test for query without keyConditionExpression
50be4b3
@simonmumenthaler
test(dynamo-rx): add test for makeRequest
5826b7f
@coveralls
Copy link

coveralls commented Nov 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+10.3%) to 86.549% when pulling e18c4a4 on #80-enhance-tests into bb9ab50 on beta.

@michaelwittwer michaelwittwer changed the base branch from master to beta November 30, 2018 09:32
michaelwittwer
michaelwittwer requested changes Nov 30, 2018
View reviewed changes
Copy link
Member

@michaelwittwer michaelwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test for abstract Request class where we create an implementation inline, i think it is less implicit than testing in either query or scan request

@michaelwittwer michaelwittwer merged commit 24017b9 into beta Nov 30, 2018
@michaelwittwer michaelwittwer deleted the #80-enhance-tests branch November 30, 2018 20:34
@michaelwittwer
Copy link
Member

🎉 This PR is included in version 4.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@michaelwittwer
Copy link
Member

🎉 This PR is included in version 5.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@michaelwittwer
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@renovate renovate bot mentioned this pull request Aug 31, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelwittwer michaelwittwer michaelwittwer approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonmumenthaler @coveralls @michaelwittwer