Skip to content

metrics: Expose server status #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

metrics: Expose server status #196

merged 1 commit into from
Nov 15, 2022

Conversation

pierreprinetti
Copy link
Contributor

New metric openstack_server: OpenStack servers by status. Useful to track ERRORed instances.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mdbooth
mdbooth suggested changes Nov 15, 2022
View reviewed changes
metrics.sh
done


metric=openstack_server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be openstack_server_status

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in my first iteration. But then I thought: shall we reflect the attributes in the metric? That's really the number of existing servers. Shall the metric name reflect the fact that the list is broken down by status?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm sold.

/lgtm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was easier than expected

@pierreprinetti
metrics: Expose server status
10e08d8 
New metric openstack_server: OpenStack servers by status.
Useful to track ERRORed instances.
@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 44526f3 into main Nov 15, 2022
@openshift-merge-robot openshift-merge-robot deleted the errored_instances branch November 15, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

1 more reviewer

@mdbooth mdbooth mdbooth requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@mdbooth mdbooth

Labels

approved lgtm

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierreprinetti @mdbooth @mandre @openshift-merge-robot