Remove potential stale ports before cleaning subnet #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy and az jobs create resources that may not be cleaned up upon job completion. One such example was seen in https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az/1632828398344605696 where the leftover port on the proxy machine subnet caused the cleanup script to fail.
mandre
force-pushed
the
clean-stale-ports
branch
from
d24ffc8 to
de7be2a
Compare
| for r in $(./stale.sh -q "$resource"); do | ||
| network=$(openstack subnet show "$r" -c network_id -f value) | ||
| ports=$(openstack port list --network "$network" -f value -c id) | ||
| for port in $ports; do |
There was a problem hiding this comment.
Have you considered adding port to the list above?
for resource in 'loadbalancer' 'server' 'router' 'PORT' 'subnet' '
There was a problem hiding this comment.
Yes I have, but didn't to do it because we'll probably have to handle too many exceptions.
There was a problem hiding this comment.
ok then, let's see how this goes.
pierreprinetti
approved these changes
Mar 9, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy and az jobs create resources that may not be cleaned up upon job completion.
One such example was seen in
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az/1632828398344605696 where the leftover port on the proxy machine subnet caused the cleanup script to fail.