Skip to content

Conversation

EmilienM
Copy link
Contributor

This script will generate a temporary file with all the ssh keys of the
approvers of a given group in the OWNERS_ALIASES file of a given project.
The script will return the path of the temporary file.
The script will return 1 if the script fails to curl the OWNER_ALIASES file
or if the yq command is not found.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This script will generate a temporary file with all the ssh keys of the
approvers of a given group in the OWNERS_ALIASES file of a given project.
The script will return the path of the temporary file.
The script will return 1 if the script fails to curl the OWNER_ALIASES file
or if the yq command is not found.
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit dda439f into main Mar 23, 2023
@openshift-merge-robot openshift-merge-robot deleted the ssh_keys branch March 23, 2023 08:24
# shellcheck disable=SC2016
MEMBERS=$(echo "$OWNER_ALIASES" | yq --arg team_name "$TEAM_NAME" -r '.aliases[$team_name] | join(" ")')

TMP_FILE=$(mktemp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you print to stdout, and you let the caller redirect where they like?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed in #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants