Expose the networkType config in run_ocp

[vkmc]

Make the networkType configurable depending on the OCP version to use.

For now, default to OpenShiftSDN.

OpenShiftSDN was deprecated in OCP 4.15 and will be removed in OCP 4.16

[openshift-ci]

Hi @vkmc. Thanks for your PR.

I'm waiting for a shiftstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vkmc]

Related notes available in https://access.redhat.com/documentation/en-us/openshift_container_platform/4.15/html-single/release_notes/index#ocp-4-15-deprecation-sdn

[pierreprinetti]

Thank you! I think you can safely default to KubernetesOVN

[vkmc]

I don't want to break any automation if we default to KubernetesOVN, that's the reason I just left OpenShiftSDN. Do we know where shiftstack-ci is being used? Is that change safe?

[openshift-ci]

@csibbitt: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierreprinetti]

we do not use this in our CI. However I am going to merge your patch because it’s perfectly backwards-compatible, and we’ll change the default later.

[pierreprinetti]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csibbitt, pierreprinetti, vkmc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment