Skip to content

Conversation

AlphaRomeoMike
Copy link

This PR link to #11 to add user configurable path for adonis_resque

Copy link

socket-security bot commented Jul 7, 2025

@AlphaRomeoMike
Copy link
Author

@shiny will it be an issue if I add a new package to the dependencies of this lib? I have added fast-glob to allow glob processing. I have also bumped a few versions of packages.

@AlphaRomeoMike AlphaRomeoMike changed the title Feature/user configured jobs directory Feature: User Configured Jobs directory Jul 7, 2025
@shiny
Copy link
Owner

shiny commented Jul 7, 2025

Thank you for your contribution! Regarding this PR, I don't think the new dependency is necessary — fsImportAll already supports a filter method. (Just a side note: @poppinss/utils is a core AdonisJS library.)
In general, we try to avoid introducing extra dependencies unless truly needed.

Secondly, the name jobsGlob feels a bit too geeky. Do you have a more elegant or intuitive alternative in mind?

@AlphaRomeoMike
Copy link
Author

Thank you for your contribution! Regarding this PR, I don't think the new dependency is necessary — fsImportAll already supports a filter method. (Just a side note: @poppinss/utils is a core AdonisJS library.) In general, we try to avoid introducing extra dependencies unless truly needed.

Secondly, the name jobsGlob feels a bit too geeky. Do you have a more elegant or intuitive alternative in mind?

Thanks for the feedback here @shiny.

  • I will take a look at the filter option
  • If the name is too geeky, I think jobsPath will be a better alternative.

Let me know if you find that suitable

- remove external dependency
- use fsImportAll to import jobs path
@AlphaRomeoMike
Copy link
Author

AlphaRomeoMike commented Jul 7, 2025

@shiny kindly review now, I am now using the path instead of the using glob matching

@AlphaRomeoMike
Copy link
Author

@shiny any update?

@shiny
Copy link
Owner

shiny commented Jul 10, 2025

We can skip glob support for now and only allow a custom directory to be specified.
Also, we shouldn't use filter to enforce that files end with jobs. this could even break the examples.

@AlphaRomeoMike
Copy link
Author

@shiny I have updated the path, can you kindly check now?

@shiny shiny mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants