Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgm_pixelflut: select is bad. #62

Merged
merged 11 commits into from
Dec 25, 2018
Merged

bgm_pixelflut: select is bad. #62

merged 11 commits into from
Dec 25, 2018

Conversation

vifino
Copy link
Member

@vifino vifino commented Oct 28, 2018

Steps to ensure pixelflut world domination.

Performance:

  • taskpool thread pinning
  • keep a good fdset for select
  • add epoll variant
  • add kqueue variant

Features:

  • alpha blending

Bugs:

  • Doesn't properly exit. Causes CI failure. Mutex/exit FD related?

right now, the pixelflut server works well for big packets on a single client.
but everything else is really limiting concurrency because of that select.

should fix #49.

Stary2001 and others added 2 commits October 28, 2018 22:59
postmature optimization is the root of all fasterness.
@vifino vifino added enhancement Enhancement suggestions to the project. tschunk Relevant persons are supposed to be rewarded with Tschunk. labels Oct 28, 2018
@vifino vifino added this to the 35C3 milestone Nov 6, 2018
@vifino vifino merged commit 8bbeb29 into master Dec 25, 2018
@vifino vifino deleted the select-is-bad branch January 29, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement suggestions to the project. tschunk Relevant persons are supposed to be rewarded with Tschunk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bgm_pixelflut: random stutter
3 participants