Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Consider having shipit.local promise reject with the same object as the resolve #154

Closed
wesdean opened this issue Aug 4, 2017 · 1 comment
Closed

Consider having shipit.local promise reject with the same object as the resolve #154

wesdean opened this issue Aug 4, 2017 · 1 comment
Assignees
@gregberge
Labels
feat shipit-cli ssh-pool
Milestone
v4.0.0

Comments

@wesdean
Copy link
Contributor

wesdean commented Aug 4, 2017

Currently a string error trace gets returned on a rejection. This string is very messy to use for controlling code flow. I find it a lot easier to read the stderr string. It would be great if an object was returned that gave us options so we could use the value the best suites the situation.
@timkelty
Copy link
Member

timkelty commented Aug 4, 2017

Sounds reasonable. PRs welcome, otherwise I'll try to get to it.

@wesdean wesdean mentioned this issue Aug 4, 2017
Merged
@gregberge gregberge mentioned this issue Aug 14, 2017
Merged
@gregberge gregberge added the feat label Aug 14, 2017
@gregberge gregberge self-assigned this Aug 14, 2017
@gregberge gregberge modified the milestone: v4.0.0 Aug 14, 2017
This was referenced Aug 14, 2017
Closed
Closed
gregberge added a commit that referenced this issue Aug 25, 2017
@gregberge
feat: standardize command exec return
d98104d 
Relative to #154
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gregberge gregberge

Labels
feat shipit-cli ssh-pool
Milestone
v4.0.0
Development

No branches or pull requests
3 participants
@timkelty @gregberge @wesdean