Adapting Vessel.js to ES6 class

[ferrari212]

No description provided.

[icarofonseca]

Our first goal might be to convert DerivedObject, Hull, Structure and ShipState to the new convention.

Then we can try to rebuild this app with modules.

[icarofonseca]

As far as I understood Classes syntax, there were some mistakes on the BaseObject.js. I am using the following link for reference: mrdoob/three.js#19980 (comment)

[ferrari212]

As far as I understood Classes syntax, there were some mistakes on the BaseObject.js. I am using the following link for reference: mrdoob/three.js#19980 (comment)

Good references Ícaro. This gives handy tricks to exchange properly from function to class.

[ferrari212]

I created a test folder which contains possible test files we can start using for now on. I created a playground.js script which contains the ship version instantiated by the two forms. The idea is to compare the two methods to ensure both of them present the same results.

[ferrari212]

I created a project Kanban to track which of the elements are already modified to avoid double work. In addtion, I already finnshed recreating the most crucial modules as agreed in the comment above:

Our first goal might be to convert DerivedObject, Hull, Structure and ShipState to the new convention.

Then we can try to rebuild this app with modules.

With that accomplishement the app stated can be recreated. I assume it fits best inside the folder tester. In addition, be aware I am testing each one of the modules in the ./tests/playground.html.

[ferrari212]

With the completion of the commit 2e9dea6 we reached the milestone defined in #165 (comment). Check the tests/playground.html to see the results.

[ferrari212]

The new version using class were not behaving as intend and was retriving undefined in the new class style instead of the value expected for the volume in this line:

vesseljs/source/classes/Hull.js

Line 509 in 72ec010

V2 = this.calculateAttributesAtDraft(t)["Vs"] - VT;

As solution, I modified the method which were returning a function to return the final object instead. The results seems ok for the tests done so far:

vesseljs/source/jsm/ship/Hull.js

Line 398 in 14541f9

calculateAttributesAtDraft( T ) {

For a comparison here is the function as it was before:

vesseljs/source/classes/Hull.js

Line 322 in 72ec010

calculateAttributesAtDraft: function() {

I do not know why this function was designed that way in the first place and I am not sure about the implications in terms of efficiency or applicability of this modification, therefore, I am making this comment in case someone has better idea how to handle this specific part of the code.

[icarofonseca]

Merge the PR to dev so it is possible to start with more thorough tests of examples.