Two minor SGT fixes, hopefully #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2022
MarkSuckerberg
pushed a commit
that referenced
this pull request
Jan 14, 2022
This was referenced Jan 14, 2022
Closed
MrRomainzZ
pushed a commit
to MrRomainzZ/Shiptest-R
that referenced
this pull request
Sep 25, 2024
* Делаем быстрее загрузку патронов с коробки * Устраняем магическую загрузку патронов с пола в магазин --------- Signed-off-by: MrCat15352 <125268716+MrCat15352@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Two fixes that will hopefully reduce the amount of SGT incidents, both have been in the code as long as my overmap has existed, but both are niche and probably only account for a few of the incidents. Nonetheless, it's good to have. Tested AF
Fix 1: Passes the docking location as a weakref when invoking the timer which calls the docking completion proc. This ensures absolutely that if the location someone is docking at is deleted somehow, they aren't affected by it.
Fix 2: Actually passes the docking location argument in a repeat backup timer invocation, this is very likely to have caused SGT issues in the past.
Why It's Good For The Game
SGT bad
Changelog
🆑
fix: Probably a few more potential SGT/random ship deletion bugs have been resolved.
/:cl: